New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't compile for Node.js & require native modules #175

Closed

anmonteiro opened this issue Sep 8, 2017 · 1 comment

anmonteiro commented Sep 8, 2017

Because new CLJS adds native node modules to the compiler env when target is Node, this line is now incorrect.

https://github.com/boot-clj/boot-cljs/blob/master/src/adzerk/boot_cljs/impl.clj#L17

see https://github.com/clojure/clojurescript/blob/998933f5090254611b46a2b86626fb17cabc994a/src/main/clojure/cljs/env.cljc#L59

Contributor

Deraen commented Sep 8, 2017

What is incorrect? We need to also pass in options?

Deraen mentioned this issue

Initialize compiler state with opts #176

Merged

Deraen closed this as completed in #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment