You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been experimenting with uber and jar tasks in boot. It seems to me that META-INF/MANIFEST.MF may get overwritten if one already exists in the file-set in the jar task. This may happen if a library provides a manifest and is exploded in the uber task.
Running boot standalone I would expect a manifest entry with only the required properties, i.e Manifest-Version: ... and Main-Class: my.ns.main. But that does not happen if I depend on a library with existing Manifest. I assume this is due to how update-jar#L74 works:
@instilled Thanks for reporting the issue, and for taking the time to investigate. This is a bug, exactly as you describe. I'll add your fix to the 2.5.1 release we'll do today.
Hi,
I've been experimenting with
uber
andjar
tasks in boot. It seems to me thatMETA-INF/MANIFEST.MF
may get overwritten if one already exists in the file-set in thejar
task. This may happen if a library provides a manifest and is exploded in theuber
task.Example
bulid.boot
:Running
boot standalone
I would expect a manifest entry with only the required properties, i.eManifest-Version: ...
andMain-Class: my.ns.main
. But that does not happen if I depend on a library with existing Manifest. I assume this is due to how update-jar#L74 works:shouldn't it be:
If that's really the issue I'll happily provide a pull request.
Fabio
The text was updated successfully, but these errors were encountered: