Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I cloned the repository and ran
docker build -t phonemizer .
I received the following error:This was caused by an outdated version of pytest that comes with installing
python3-pytest
through apt. I fixed this by installingpytest
through pip. After that I had four failing tests:These were caused by the tests looking for
python
executable but onlypython3
is available when installing python via apt. I modified the Dockerfile to create a symlink to thepython
executable rather than modifying the tests themselves.You should be able to confirm that
docker build -t phonemizer .
works with the modified Dockerfile. Let me know if there is a different way you would like me to fix either of these issues!