fix(dropdowns): Minor code update & comments

bootstrap-vue · Aug 31, 2017 · 54a2546 · 54a2546
1 parent 2777380
commit 54a2546
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/mixins/dropdown.js b/lib/mixins/dropdown.js
@@ -166,14 +166,14 @@ export default {
         hideMenu() {
             // TODO: move emit hide to visible watcher, to allow cancelling of hide
             this.$emit("hide");
-            this.emitOnRoot("hidden::dropdown", this);
-            if (this._popper) {
+             if (this._popper) {
                 // Ensure popper event listeners are removed cleanly
                 this._popper.destroy();
             }
             this._popper = null;
             this.setTouchStart(false);
-            this.$emit("hidden");
+            this.emitOnRoot("bv::dropdown::hidden", this);
+           this.$emit("hidden");
         },
         getPopperConfig() {
             let placement = AttachmentMap.BOTTOM;
@@ -230,6 +230,7 @@ export default {
             this.visible = false;
         },
         click(e) {
+            // Calle only in split button mode, for the split button
             if (this.disabled) {
                 this.visible = false;
                 return;
@@ -238,6 +239,7 @@ export default {
             this.$emit("click", e);
         },
         toggle() {
+            // Called only by a button that toggles teh menu
             if (this.disabled) {
                 this.visible = false;
                 return;