Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): BCardSubTitle component declared export name #4229

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@mblonyox
Copy link
Contributor

@mblonyox mblonyox commented Oct 9, 2019

When we importing b-card-sub-title component individually, typescript throws following error:

Module '"../../node_modules/bootstrap-vue/src"' has no exported member 'BCardSubTitle'. Did you mean 'BCardSubtitle'?

Describe the PR

Fix incorrect export declaration of BCardSubTitle component.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • Yes (please describe)
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It's submitted to the dev branch, not the master branch
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
When we importing b-card-sub-title component individually, typescript throws following error:
```
Module '"../../node_modules/bootstrap-vue/src"' has no exported member 'BCardSubTitle'. Did you mean 'BCardSubtitle'?
```
@mblonyox mblonyox changed the title Fix: Card Sub Title component has no declared export fix: BCardSubTitle component declared export Oct 9, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 9, 2019

Codecov Report

Merging #4229 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4229   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         237      237           
  Lines        4525     4525           
  Branches     1274     1274           
=======================================
  Hits         4519     4519           
  Misses          5        5           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5855ffd...dc0e6ad. Read the comment docs.

@tmorehouse tmorehouse changed the title fix: BCardSubTitle component declared export fix(types): BCardSubTitle component declared export name Oct 9, 2019
@tmorehouse tmorehouse self-requested a review Oct 9, 2019
Copy link
Member

@tmorehouse tmorehouse left a comment

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants