New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[popover] [tooltip] mixin #527
Conversation
Should address issue #396
Coerce slide nodelist into an Array
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's just a solid move to mixin vs. extends. 👍
Yep... using a mixin will hep with the auto-documentation generation of supported props on both tooltip and popover. |
It looks like you also try to structure the order of template props (I've been on a mission to make my own ordering consistent). I wonder if there is a style guide for this yet. I've been working in this order more or less:
I imagine that's something the Vue community will eventually settle on. That and little things like closing the opening markup tag on the same line or a new line. |
Yeah, I find having the events last makes things easier to see, and bound stuff near the first. The closing markup tag on a newline helps show the end of attributes/bindings/events as sometimes they line up with the next child element |
We could probably use a standard set of Vetur formatting settings to keep things consistent. What editor do you use when working with Vue code? |
I'm old school and use either the github web interface, or or larger changes I edit in notepad++ :P |
I use vim as well ;-) (and vi if no vim) |
I've managed to get as far as learning how to quit vim—and I feel accomplished there! |
Any objections to this PR being merged? |
None from this guy. Onward! |
Moved common functionality + tether into popover.js mixin.
This will help auto documentation so that only applicable props are shown in each component's docs.
Currently
b-tooltip
docs list a lot of props that are only applicable tob-popover
, so this will help prevent some usage confusion such as issue #467 (#467 (comment))This PR replaces outdated PR #470, so that it incorporates changes from PR #485 which addressed issue #484