In-line rename allowed during other operations

[bigtedde]

The new in-line archive renaming feature is allowed even while a background operation is occurring. Renaming archive while other operations are happening leads to a visual bug where no archives are displayed. Restarting Vorta resolves the issue and all the archives are displayed as expected. See example below:

Steps to reproduce the behavior:

1. Open Vorta and navigate to the "archive" tab
2. Select a archive and perform an action that leads to the rename button being disabled (such as "check" or "delete")
3. While operation is occurring, double click the selected archive's name and rename to something different
4. Allow the original operation to complete
5. See that all the archives have disappeared

Environment

• OS: Mac OS Venture 13.5.1
• Vorta version: 0.9.0
• Installed from: Source
• Borg version: 1.2.4

Logs

2023-08-31 12:42:42,470 - vorta.borg.jobs_manager - DEBUG - Add job for site 1
2023-08-31 12:42:42,471 - vorta.borg.jobs_manager - DEBUG - Start job on site: 1
2023-08-31 12:42:42,473 - vorta.borg.borg_job - INFO - Running command /opt/homebrew/bin/borg delete --info --log-json ssh://vwxe9eus@vwxe9eus.repo.borgbase.com/./repo::This is archive 5
2023-08-31 12:42:44,533 - vorta.keyring.abc - DEBUG - No module named 'secretstorage'
2023-08-31 12:42:44,533 - vorta.keyring.abc - DEBUG - Using VortaDarwinKeyring
2023-08-31 12:42:44,533 - vorta.borg.borg_job - DEBUG - Using VortaDarwinKeyring keyring to store passwords.
2023-08-31 12:42:44,536 - vorta.keyring.darwin - DEBUG - Retrieved password for repo ssh://vwxe9eus@vwxe9eus.repo.borgbase.com/./repo
2023-08-31 12:42:44,549 - vorta.borg.jobs_manager - DEBUG - Add job for site 1
2023-08-31 12:42:47,769 - vorta.borg.borg_job - INFO - Remote: Storage quota: 1.09 GB out of 10.00 GB used.
2023-08-31 12:42:48,651 - vorta.borg.borg_job - INFO - Remote: Storage quota: 1.09 GB out of 10.00 GB used.
2023-08-31 12:42:49,180 - vorta.borg.jobs_manager - DEBUG - Finish job for site: 1
2023-08-31 12:42:49,181 - vorta.borg.jobs_manager - DEBUG - Start job on site: 1
2023-08-31 12:42:49,182 - vorta.scheduler - INFO - Setting timer for profile 1
2023-08-31 12:42:49,183 - vorta.borg.borg_job - INFO - Running command /opt/homebrew/bin/borg rename --info --log-json ssh://vwxe9eus@vwxe9eus.repo.borgbase.com/./repo::This is archive 5 This is archive asdfad5
2023-08-31 12:42:49,190 - vorta.scheduler - DEBUG - Scheduling next run for 2023-09-01 12:00:00
2023-08-31 12:42:53,073 - vorta.borg.borg_job - ERROR - Archive This is archive 5 does not exist
2023-08-31 12:42:53,214 - vorta.borg.jobs_manager - DEBUG - Finish job for site: 1
2023-08-31 12:42:53,215 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: 1```

[bigtedde]

I can work on a fix for this. My immediate thought was just to add a check in cell_double_clicked of ArchiveTab to see if the "Rename" button is enabled or not, and ignore the double click if it is not.

[m3nu]

Good find! Yes, a fix would be appreciated for sure.