Fix slow dynamic cast for Point3 and Point2 #1168
Merged
+27
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @dellaert for 2nd round review. |
dellaert
approved these changes
Apr 12, 2022
|
Awesome !!!! |
ProfFan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1165
Before:
optimizer ran: 63 iterations, time took: 38.46747899055481 seconds, initial error: 7505.995184644436, final error: 5742.671242796094After
optimizer ran: 63 iterations, time took: 4.811146020889282 seconds, initial error: 7505.995184644436, final error: 5742.671242796094on my M1 max mac