-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verdant/boost serialization #1409
Verdant/boost serialization #1409
Conversation
@ProfFan tagged you for review and advice. We might do another PR down the line with your help to include "cereal", but this one at least allows compilation without boost for the most part. After this PR, I envision only one or more two PRs are needed to make that happen. |
CI fails, and somehow the diff did not update. I'd recommend (a) merging in develop again, and (b) - before pushing- figuring out what is killing the CI. |
|
That's weird I don't remember modifying GtsamTesting.cmake |
But I did change the files that called it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!!
This PR introduces a new flag to disable boost serialization functionality. Another move towards being able to build GTSAM without boost. Implemented this mainly through a compile time definition that conditionally deactivates all references to boost serialization.
Question for the reviewers:
Note:
If you see some code changes in the diff that don't seem to be part of this PR, it's because it has changes from another branch (
feature/remove_boost_in_Values
) and will go away when that branch gets merged, which will happen before this will go in.