Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused body_P_sensor param #744

Merged
merged 2 commits into from
Apr 18, 2021
Merged

Remove unused body_P_sensor param #744

merged 2 commits into from
Apr 18, 2021

Conversation

asa
Copy link
Contributor

@asa asa commented Apr 17, 2021

Parm is mentioned but no longer used in CombinedImuFactor.

@dellaert
Copy link
Member

dellaert commented Apr 17, 2021 •
edited

Why not? Was there a PR removing its use? Should the right PR be to add that functionality?

@asa
Copy link
Contributor Author

asa commented Apr 17, 2021

I am not sure of the history on this? Just noticed we had a param mentioned, but not interface for it and thought we might want to remove it till it's implemented or notate it as a todo.

@varunagrawal
Copy link
Collaborator

I thought body_P_sensor was defined on the PreintegrationParams and not on the factor itself. As such removing that comment should be the right thing to do.

@varunagrawal
Copy link
Collaborator

@asa can you also update the docstring for dt. It is right above your edit and is labelled as deltaT.

@dellaert I can confirm this is the case. There was a refactor 6 years ago to define PreintegrationParams and it seems the docstrings were not updated.

varunagrawal
varunagrawal approved these changes Apr 18, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor request.

gtsam/navigation/CombinedImuFactor.h Outdated
@@ -212,8 +212,6 @@ class GTSAM_EXPORT PreintegratedCombinedMeasurements : public PreintegrationType
* sensor)
* @param measuredOmega Measured angular velocity (as given by the sensor)
* @param deltaT Time interval between two consecutive IMU measurements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation for this parameter as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@varunagrawal varunagrawal added the docs Update to docs or README without code changes label Apr 18, 2021
@varunagrawal varunagrawal merged commit 329e70e into borglab:develop Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees

@asa asa

Labels
docs Update to docs or README without code changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asa @dellaert @varunagrawal