add missing interface for PoseTranslationPrior #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beetleskin
force-pushed
the
fix/add_missing_interface_functions_for_poseprior
branch
from
54481c0
to
40c9da5
Compare
|
Thanks for the PR @StefanKaiser-TomTom. Yeah that is an oversight of ours in the wrapper. You should be able to call We are already working towards removing the need to define |
|
Great! thanks both! |
beetleskin
deleted the
fix/add_missing_interface_functions_for_poseprior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change is straight forward.
However, I'm not fully aware how the pickle() works .. I can't call it from Python even though its listed in the interface and some stuff is done in the wrapper?
Lastly, I'd put up some unit-tests but would need some guidance where to put it, and how you want those interfaces being tested (or maybe you don't want to test them at all for the sake of flexibility?).