Add wrapper fixes for Matlab memory leak #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cbaf7a3a Merge pull request #131 from borglab/remove-pickle 0c2a4483c add documentation 2e5af11ad Merge pull request #139 from borglab/fix/matlab-memory-leak 442b7d3b0 update test fixtures f89d5e4bd delete object after clearing it from object collector 971282703 add the correct variable for RTTI registry creation 9758dec57 update test fixture 87aeb8f8c remove need for declaring pickle function in interface file git-subtree-dir: wrap git-subtree-split: 2cbaf7a3a628766ff40657e0150b407ed4af7ccd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls the latest updates from
gtwrapwhich has fixes for a memory leakage in the matlab wrapper.@mattking-smith has already verified this works well, so it should be an easy approval.
This PR also removes the need to add a separate pickle method in the interface file. As long as a class has a
serializemethod,picklewill also be added.