Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ON before printing is "stuck" activated, despite NOT being activated in settings! #52

Closed
IAmOrion opened this issue May 25, 2022 · 5 comments · Fixed by #55 or #77
Closed

ON before printing is "stuck" activated, despite NOT being activated in settings! #52

IAmOrion opened this issue May 25, 2022 · 5 comments · Fixed by #55 or #77
Labels
bug Something isn't working

Comments

@IAmOrion
Copy link

Screenshot 2022-05-26 at 00 44 30

As you can see in my screenshot, "ON before printing" is NOT ticked/active. Yet, every time I start a print, the relay turns on!
With my relay board, the inverted output is required. For all intents and purposes it works as expected if I manually toggle the relay control. It also correctly turns OFF when a print is finished as expected. I just don't want it turning on when a print starts... but for some reason it does.

@shooter-z
Copy link

Can confirm. Octorelay 1.2.0 running on raspberry pi.
It is not a display bug, since behaviour is the same whenever "ON before printing" is enabled or disabled.

@IAmOrion
Copy link
Author

I'm assuming this plugin is dead/no longer supported. :(

@hcooper
Copy link
Contributor

hcooper commented Nov 28, 2022

@IAmOrion @shooter-z I've not tested your exact problem, however I fixed an issue with "on before printing" not working for me, and I suspect it's similar to your problem.

#55

The issue was that the print_started() function, was processing all relay configs, not just the "enabled ones". And by chance the default configs for another relay were trying to use the same pin as me.

From your screenshot I see you're using pin 23. That's the same pin the default config for Relay 4 uses. Until my PR is committed, try changing Relay 4 config to a different/fake pin and see if that fixes your problem.

@IAmOrion
Copy link
Author

IAmOrion commented Dec 1, 2022

@hcooper - well done discovering that! That fixed the problem for me, thanks for the info.

@RobinTail RobinTail linked a pull request Jul 2, 2023 that will close this issue
@RobinTail RobinTail added the bug Something isn't working label Jul 19, 2023
@RobinTail
Copy link
Collaborator

🚀 @IAmOrion , the issue should be fixed in v1.4.1.
Please check it out, and in case it's not, please create another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants