Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In reader conditionals take :bb OR :clj branch (in that order) #267

Closed
borkdude opened this issue Feb 17, 2020 · 0 comments
Closed

In reader conditionals take :bb OR :clj branch (in that order) #267

borkdude opened this issue Feb 17, 2020 · 0 comments

Comments

@borkdude
Copy link
Collaborator

borkdude commented Feb 17, 2020

Libraries like regal work just fine with babashka, but because they have no explicit :bb branch in their reader conditionals, many functions just return nil. Instead, babashka could just take the first :bb OR :clj branch with a priority for :bb. Still we have no guarantee that the library maintainer is willing to check compatibility with bb for future versions unless they explicitly state it, so it might always make sense to fork and curate these libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant