Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coveralls integration #34

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Add coveralls integration #34

merged 2 commits into from
Mar 3, 2021

Conversation

jcorbin
Copy link
Collaborator

@jcorbin jcorbin commented Mar 1, 2021

No description provided.

@jcorbin
Copy link
Collaborator Author

jcorbin commented Mar 1, 2021

Wanted to try out coveralls, but am nut sure if we should actually go with it.

Related: I'd like to fix our hacked "100%"s by dropping all ignore comments and lowering check thresholds to reflect actual coverage.

Corollary: we're not including --all files in the coverage check, rather only included files; I'd rather switch to nyc's "all sources" mode, and then explicitly list which files to exclude.

Thoughts @kriskowal ?

This was referenced Mar 2, 2021
@jcorbin jcorbin marked this pull request as ready for review March 3, 2021 00:36
@jcorbin jcorbin merged commit 9c0d097 into main Mar 3, 2021
@jcorbin jcorbin deleted the coveralls branch March 3, 2021 00:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants