Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `merge` as an alias for `r+` #746

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@DilumAluthge
Copy link
Contributor

DilumAluthge commented Sep 15, 2019

This pull request implements the following RFC: Allow merge as an alias for r+

Specifically, this pull request adds the following aliases:

Alias added in this PR Existing command
bors merge bors r+
bors merge=FOO bors r=FOO
bors merge p=123 bors r+ p=123
bors merge=FOO p=123 bors r=FOO p=123
bors merge- bors r-
This pull request adds the following aliases:
`bors merge` -> `bors r+`
`bors merge=FOO` -> `bors r=FOO`
`bors merge p=123` -> `bors r+ p=123`
`bors merge=FOO p=123` -> `bors r=FOO p=123`
`bors merge-` -> `bors r-`
@DilumAluthge

This comment has been minimized.

Copy link
Contributor Author

DilumAluthge commented Oct 6, 2019

@notriddle Now that https://forum.bors.tech/t/allow-merge-as-an-alias-for-r/376 has been accepted, shall we merge this PR?

@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Oct 6, 2019

Agreed.

bors r+

bors bot added a commit that referenced this pull request Oct 6, 2019
Merge #746
746: Add `merge` as an alias for `r+` r=notriddle a=DilumAluthge

This pull request implements the following RFC: [Allow `merge` as an alias for `r+`](https://forum.bors.tech/t/allow-merge-as-an-alias-for-r/376)

Specifically, this pull request adds the following aliases:

| Alias added in this PR | Existing command |
| ---------------------- | ------------------ |
| `bors merge` | `bors r+` |
| `bors merge=FOO` | `bors r=FOO` |
| `bors merge p=123` | `bors r+ p=123` |
| `bors merge=FOO p=123` | `bors r=FOO p=123` |
| `bors merge-` | `bors r-` |

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Oct 6, 2019

Build succeeded

@bors bors bot merged commit 00d0040 into bors-ng:master Oct 6, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
@DilumAluthge DilumAluthge deleted the DilumAluthge:da/bors-merge-alias branch Oct 6, 2019
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.