Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI frequently fails since a recent commit #578

Closed
AndrejMitrovic opened this issue Feb 22, 2020 · 9 comments
Closed

CircleCI frequently fails since a recent commit #578

AndrejMitrovic opened this issue Feb 22, 2020 · 9 comments
Assignees
@MichaelKim20
Labels
type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Milestone
2. Validator

Comments

@AndrejMitrovic
Copy link
Contributor

AndrejMitrovic commented Feb 22, 2020 •
edited
Loading

I'm seeing this location triggered often since a recent commit:

node-2_1_18e84daf14a1 | 2020-02-22T12:01:40.224084227Z core.exception.AssertError
@source/scpd/types/Stellar_SCP.d(118): Assertion failure

Technically this should not happen. The SCPStatement._pledges_t.type should always be one of the four defined types.

It's probably related to some of the C++ issues listed in [#561, #560, #559].

I don't think a recent commit is the cause of the issue, but just something which triggers the symptom.
@AndrejMitrovic AndrejMitrovic added the type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense label Feb 22, 2020
@Geod24 Geod24 added this to the 2. Validator milestone Feb 25, 2020
@AndrejMitrovic
Copy link
Contributor Author

AndrejMitrovic commented Mar 10, 2020 •
edited
Loading

This one can reproduce failures: #641 and I think it's related to the failures we had in CircleCI.

@Geod24
Copy link
Collaborator

Geod24 commented Mar 10, 2020

We also have #553 which seems related.

@AndrejMitrovic
Copy link
Contributor Author

Actually #641 does not seem to be related. Because CircleCI does not fail on it (but other CI systems fail).

@AndrejMitrovic
Copy link
Contributor Author

Still fails here: https://app.circleci.com/jobs/github/bpfkorea/agora/1643

@MichaelKim20 MichaelKim20 mentioned this issue Mar 12, 2020
Closed
@MichaelKim20
Copy link
Member

We also have #553 which seems related.

I have looked at the contents of #553 several times.

Running ./build/agora-unittests 
terminate called after throwing an instance of 'std::invalid_argument'
  what():  invalid public key type
Program exited with code -6
The command "./ci/run.sh" exited with 2.

By the way, I found that #553 is less relevant to the current issue.
I think it has something to do with TravisCI.
I think it is good to separate #553 and solve it. What do you think?

@Geod24
Copy link
Collaborator

Geod24 commented Mar 12, 2020

If you think so, fine by me. They were filled as separate issue after all.

@Geod24
Copy link
Collaborator

Geod24 commented Mar 12, 2020

Still fails here: https://app.circleci.com/jobs/github/bpfkorea/agora/1643

This is unrelated, it's your PR.

@Geod24
Copy link
Collaborator

Geod24 commented Mar 12, 2020

One can filter the branch through this URL: https://app.circleci.com/pipelines/github/bpfkorea/agora?branch=v0.x.x

Here are some of the failures I could see:

Etc...

@Geod24
Copy link
Collaborator

Geod24 commented Mar 12, 2020

Most likely solved by #620

@Geod24 Geod24 closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelKim20 MichaelKim20

Labels
type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Projects
None yet
Milestone
2. Validator
Development

No branches or pull requests
3 participants
@Geod24 @MichaelKim20 @AndrejMitrovic