Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Custom version of zserge/webview #34

Closed
wendivoid opened this issue Oct 24, 2018 · 2 comments
Closed

Use Custom version of zserge/webview #34

wendivoid opened this issue Oct 24, 2018 · 2 comments

Comments

@wendivoid
Copy link

I've been using web-view for a while now, and i have to use a custom version of zserge/webview. Since i use your bindings i would also have to maintain web-view & web-view-sys crates. It would be interesting if there was a way to specify a fork of the webview repository for use instead of zserge/webview@master. I have no idea how this could work but i imagine since webview is a new library lot's of people might find themselves needing to use a custom webview repo. If you have any idea's on how this could be implemented I'd be willing to work on it and submit a PR.

@Boscop
Copy link
Owner

Boscop commented Oct 30, 2018

Hm, I'm not sure what the best way is to do this..

Because it's not just something that can be done with a cargo feature, without including all the customizations in the main crate..

But maybe your customizations could become part of the main crate if it makes sense. What were the customizations you did to webview, btw?

@wendivoid
Copy link
Author

I made an issue about it #50.
I simple called the webkit_settings_set_allow_file_access_from_file_urls function from webkit2gtk so i could just use relative urls with file url's. I don't think it'll make it to into webview for a while because i've only added this feature to the gtk backend.

i'm not sure how to do this with windows & macos backends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants