-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync watcher #814
Sync watcher #814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
==========================================
- Coverage 61.97% 60.66% -1.32%
==========================================
Files 151 152 +1
Lines 9913 10135 +222
==========================================
+ Hits 6144 6148 +4
- Misses 3109 3319 +210
- Partials 660 668 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super fast impl. 👍
9acb021
to
ca97589
Compare
ca97589
to
7cd87df
Compare
2d12e99
to
3d0f052
Compare
3d0f052
to
7068cb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, I want to have more time for this :)
69f347a
to
4f87269
Compare
4f87269
to
c6b7850
Compare
Ping @Charleslee522 :-> Plz review it :-> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Github Issue
Fixes #734
Background
sebak node watcher mode watches it's validators and try to sync. with this mode, the node don't join consensus.
Solution
watcher-mode
, Node don't startInitRound
. and startsync.Watcher
.Possible Drawbacks
--watcher-mode=1
can make standby validator. If active validator is down, we can change only--watcher-mode=0
for active validator. (maybe)