Update to Knative 0.17 + pin some dependencies #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjusted some dependencies and overwrite version to align transitive dependencies. Not sure why buildpack uses such an older docker dependency but that clases with the docker dependency that is introduced by knative-dev/test-infra (which is a dependency of the knative direct dependencies) If there is a way to exclude a transitive dependency like that on test-infra, this could be the better way to achieve the same result. The build now works on macOs natively which was not the case before.
|
Please note that this will also update buildpacks to 0.14.0 (released today) |
|
/hold |
rhuss
changed the title
rhuss
changed the title
matejvasek
reviewed
Oct 2, 2020
| github.com/spf13/cobra v1.0.0 | ||
| github.com/stretchr/testify v1.5.1 // indirect | ||
| golang.org/x/sys v0.0.0-20200728102440-3e129f6d46b1 // indirect | ||
| github.com/spf13/cobra v1.0.1-0.20200715031239-b95db644ed1c |
There was a problem hiding this comment.
I like to see this. This version contains fixes for zsh completion 👍
lance
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adjusted some dependencies and overwrite version to align
transitive dependencies.
Not sure why buildpack uses such an older docker dependency but that
clases with the docker dependency that is introduced by knative-dev/test-infra
(which is a dependency of the knative direct dependencies)
If there is a way to exclude a transitive dependency like that on test-infra,
this could be the better way to achieve the same result.
The build now works on macOs natively which was not the case before.