Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Knative 0.17 + pin some dependencies #145

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Oct 1, 2020

Also adjusted some dependencies and overwrite version to align
transitive dependencies.

Not sure why buildpack uses such an older docker dependency but that
clases with the docker dependency that is introduced by knative-dev/test-infra
(which is a dependency of the knative direct dependencies)

If there is a way to exclude a transitive dependency like that on test-infra,
this could be the better way to achieve the same result.

The build now works on macOs natively which was not the case before.

Also adjusted some dependencies and overwrite version to align
transitive dependencies.

Not sure why buildpack uses such an older docker dependency but that
clases with the docker dependency that is introduced by knative-dev/test-infra
(which is a dependency of the knative direct dependencies)

If there is a way to exclude a transitive dependency like that on test-infra,
this could be the better way to achieve the same result.

The build now works on macOs natively which was not the case before.
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhuss
Copy link
Contributor Author

rhuss commented Oct 1, 2020

Please note that this will also update buildpacks to 0.14.0 (released today)

@rhuss
Copy link
Contributor Author

rhuss commented Oct 1, 2020

/hold

@rhuss rhuss changed the title Update to Knative 0.17 + pin some dependencies [WIP] Update to Knative 0.17 + pin some dependencies Oct 1, 2020
@rhuss rhuss changed the title [WIP] Update to Knative 0.17 + pin some dependencies Update to Knative 0.17 + pin some dependencies Oct 2, 2020
github.com/spf13/cobra v1.0.0
github.com/stretchr/testify v1.5.1 // indirect
golang.org/x/sys v0.0.0-20200728102440-3e129f6d46b1 // indirect
github.com/spf13/cobra v1.0.1-0.20200715031239-b95db644ed1c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to see this. This version contains fixes for zsh completion 👍

@lance lance merged commit 5fe7052 into knative:main Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants