Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpleflow.activity.Activity timeout arguments aren't optional #36

Open
mprecise opened this issue Apr 15, 2015 · 1 comment
Open

simpleflow.activity.Activity timeout arguments aren't optional #36

mprecise opened this issue Apr 15, 2015 · 1 comment

Comments

@mprecise
Copy link

I created all of my activity types, workflow types, and domains manually in the AWS console before I began using simpleflow, so I have no experience trying to register these types using simpleflow. Since my types were pre-registered, I thought I'd be able to leave off all four of the timeout parameters when decorating an activity function with @simpleflow.activity.with_attributes. However, my decider received this error

  File "/usr/local/lib/python2.7/dist-packages/swf/actors/decider.py", line 53, in complete
    raise ResponseError(e.body['message'])
ResponseError: Invalid duration: None

Adding the timeouts to the decorator parameters fixed this. If these are indeed optional, I assume the fix is for the library to remove any keys whose value is None before making the request.

@ggreg
Copy link
Contributor

ggreg commented Apr 19, 2015

The problem seems to come from https://github.com/botify-labs/python-simple-workflow. I created botify-labs/python-simple-workflow#47 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants