Fall back to deprecated starting token parser #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to paginators broke customers who were manually crafting pagination tokens in services where they did not make them opaque. This adds support for the old starting token format while still returning next tokens in the new format.
JordonPhillips
added
the
pr/needs-review
| This handles parsing of old style starting tokens, and attempts to | ||
| coerce them into the new style. | ||
| """ | ||
| log.debug("Attempting to fall back to old starting token parser.") |
There was a problem hiding this comment.
Might be good to say what the token was that was received that started this attempt.
|
Looks good. You pretty much copied code from the old implementation 🚢. Did you test your implementation with some of the services where we saw regressions? It may not hurt to add an integration or functional test for one of those services like rds or route53. |
|
|
You can also use s3 as well for an integration test. There'a already some existing tests for pagination so it might be easier to build on those tests.
JordonPhillips
force-pushed
the
add-deprecated-paginator
branch
from
1fa1346
to
b39825d
Compare
|
tests added |
|
Thanks! 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to paginators broke customers who were manually crafting pagination tokens in services where they did not make them opaque. This adds support for the old starting token format while still returning next tokens in the new format. If we are unable to parse the starting token in the new format, we'll attempt to parse it with the old format.
This addresses the root cause of aws/aws-cli#1835, but the docs should be updated to reflect the new tokens.
cc @kyleknap @jamesls