Remove reference to old starting token format in docs #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
added
pr:needs-review
|
|
. Regarding, RDS my preference is to keep it as is for now.
|
It looks like all of these examples have been converted to Unicode files in this PR; they have non-ascii dashes in them that break the HTML builds. The AWS CLI reference seems to be able to convert the characters properly, which is probably why it doesn't break the Travis CI build, but local HTML builds on Mac and Ubuntu are failing. Is there a way we can block non-ascii files from being committed to the AWS CLI examples? Or add a test that at least checks that the files are ASCII and break the Travis CI build with an error if they are not? |
|
Yeah, I'm going to add a test for this now to ensure this doesn't happen again. |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one last remaining bit of the old world left, the RDS docs mentioned in #1835. There is a pr up at boto/botocore#849 to fix the code bug there, but the doc here is a bit challenging.
RDS is using the
Markervalue0to indicate that it will start at the beginning of the logs. I'm not sure how I feel about transforming our docs to show--starting-token eyJNYXJrZXIiOiAiMCJ9or showing--Marker 0instead. We could also potentially make another flag (--start-at-beginning) to suit this scenario. What do you guys think?cc @kyleknap @jamesls