fix(flow): some refactor for flows #2164
Conversation
| @@ -119,7 +119,7 @@ class LoggerView extends Component { | |||
| <ul className={styles.events}>{logs}</ul> | |||
| </div> | |||
| {canLoadMore && ( | |||
| <div href="#" className={styles['logs-panel-footer']} onClick={this.loadMore}> | |||
| <div className={styles['logs-panel-footer']} onClick={this.loadMore}> | |||
There was a problem hiding this comment.
I think we can get rid of this file entirely
There was a problem hiding this comment.
I'll remove it in a subsequent PR, I removed the # because it caused issue with baseurl, but it was unnecessary
src/bp/common/typings.ts
Outdated
| links: NodeLinkView[] | ||
| } | ||
|
|
||
| export type NodeLinkView = { |
There was a problem hiding this comment.
In a traditional graph, that would be called an edge
There was a problem hiding this comment.
Existing typings that i've moved, I didn't thought much about renaming them
| import _ from 'lodash' | ||
| import Mustache from 'mustache' | ||
| import React, { Component } from 'react' | ||
| import { OverlayTrigger, Popover, Well } from 'react-bootstrap' |
There was a problem hiding this comment.
can't we use blueprint components instead ?
There was a problem hiding this comment.
It's existing code that i've copy-pasted, since we're gonna change all that soon I didn't bother to convert it. It keeps the same look as old nodes (since they are temporary)
There was a problem hiding this comment.
ok cool but let's add a TODO because we're going to migrate the styling to blueprint before we get rid of the nodes
| <a href="#" onClick={this.markAllAsRead}> | ||
| Mark all as read | ||
| </a> | ||
| <a onClick={this.markAllAsRead}>Mark all as read</a> |
There was a problem hiding this comment.
is the notification hub even working ? I mean do we even send notification somewhere ?
There was a problem hiding this comment.
Yeah, still used in HITL for now
| showActionModalForm: false | ||
| } | ||
|
|
||
| itemToOptions(item) { |
There was a problem hiding this comment.
that's some parsing magic, I'm totally out of context I know but do you think we could eventually get rid of this ?
There was a problem hiding this comment.
Not the way nodes are done in flow v1. I've copied the code from ActionModalForm but made it into a smaller component for that purpose, but all this is throwable
| import _ from 'lodash' | ||
| import Mustache from 'mustache' | ||
| import React, { Component } from 'react' | ||
| import { OverlayTrigger, Popover, Well } from 'react-bootstrap' |
There was a problem hiding this comment.
ok cool but let's add a TODO because we're going to migrate the styling to blueprint before we get rid of the nodes
src/bp/ui-studio/src/web/views/FlowBuilder/diagram/nodes_v2/style.scss
Outdated
Show resolved
Hide resolved
Added basis for new node types. Also fixes some issues left of my pr of custom URL that i've encountered..