fix sync issue #2233
Merged
fix sync issue #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EFF
approved these changes
Aug 13, 2019
| const botId = parts[parts.indexOf('actions') - 1] | ||
|
|
||
| // Debouncing invalidate since we get a lot of events when it happens | ||
| private _invalidateRequire() { |
There was a problem hiding this comment.
not that I care about this change to be made but what about :
private _invalidateRequire = _.debounce(() => {
// code goes here
})
// and get rid of the constructor initialization for the func| @@ -17,7 +17,7 @@ import { VmRunner } from '../action/vm' | |||
| import { Incident } from '../alerting-service' | |||
|
|
|||
| const debug = DEBUG('hooks') | |||
| const SYNC_DEBOUNCE_DELAY = ms('2s') | |||
| const DEBOUNCE_DELAY = ms('2s') | |||
There was a problem hiding this comment.
I know its not part of this PR but it seems to me that the code here and in action service is pretty much duplicated
| @@ -215,6 +238,10 @@ export class ScopedGhostService { | |||
| await this.primaryDriver.upsertFile(fileName, content, recordRevision) | |||
| this.events.emit('changed', fileName) | |||
| await this._invalidateFile(fileName) | |||
|
|
|||
| if (syncDbToDisk) { | |||
| await this.cache.sync(JSON.stringify({ rootFolder, botId: this.botId })) | |||
There was a problem hiding this comment.
why not leave the responsibility of serializing the obj do the sync method ?
There was a problem hiding this comment.
Trying to keep the logic in redis cache minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When actions are edited using the code-editor and a database, we need to sync them back to the file system so they can be required() by actions and hooks. VM2 can't load them from the ghost.
This PR fixes an issue where there was way too many invalidate triggered for nothing. It is triggered once when a file is inserted, then it is propagated to other nodes via redis