Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(qna): handle IME-composing in QNA-form #930

Merged
merged 1 commit into from
Sep 20, 2018
Merged

fix(qna): handle IME-composing in QNA-form #930

merged 1 commit into from
Sep 20, 2018
+39 −6

Conversation

epaminond
Copy link
Contributor

Fixing an IME issue for controlled inputs within QNA-module.
An issue occurs due to onChange firing before IME composition ends (see facebook/react#3926).

@epaminond epaminond merged commit 8493314 into master Sep 20, 2018
@epaminond epaminond deleted the handle-ime-in-qna branch September 20, 2018 08:55
@epaminond epaminond restored the handle-ime-in-qna branch September 20, 2018 08:55
@epaminond epaminond deleted the handle-ime-in-qna branch September 20, 2018 08:55
@allardy allardy mentioned this pull request Dec 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slvnperron slvnperron slvnperron approved these changes

@emirotin emirotin Awaiting requested review from emirotin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epaminond @slvnperron