Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webchat): implement basic webchat #126

Merged
merged 102 commits into from
Aug 19, 2021
Merged

feat(webchat): implement basic webchat #126

merged 102 commits into from
Aug 19, 2021

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Aug 12, 2021

Implements a basic webchat to connect to the messaging server

Closes MES-123

packages/server/src/api.ts Show resolved Hide resolved
packages/board/src/app.ts Outdated Show resolved Hide resolved
packages/chat/package.json Show resolved Hide resolved
packages/chat/src/chat.ts Outdated Show resolved Hide resolved
packages/chat/src/conversation/system.ts Outdated Show resolved Hide resolved
packages/skin/src/render.ts Show resolved Hide resolved
packages/skin/src/render.ts Show resolved Hide resolved
packages/skin/src/render.ts Show resolved Hide resolved
packages/socket/src/com.ts Outdated Show resolved Hide resolved
packages/socket/src/socket.ts Outdated Show resolved Hide resolved
@samuelmasse samuelmasse marked this pull request as ready for review August 17, 2021 20:05
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!! This is really neat 🔥

packages/chat/src/chat.ts Show resolved Hide resolved
packages/chat/src/chat.ts Show resolved Hide resolved
packages/chat/src/chat.ts Show resolved Hide resolved
packages/chat/src/conversation/system.ts Outdated Show resolved Hide resolved
packages/chat/src/conversation/system.ts Outdated Show resolved Hide resolved
packages/server/src/socket/manager.ts Outdated Show resolved Hide resolved
packages/server/src/socket/service.ts Show resolved Hide resolved
packages/server/src/socket/service.ts Outdated Show resolved Hide resolved
packages/server/src/socket/service.ts Outdated Show resolved Hide resolved
packages/socket/package.json Outdated Show resolved Hide resolved
@samuelmasse
Copy link
Contributor Author

We'll look into putting the content type typings in the base package later. The send function also as a mysterious from parameter. I'll make it's usage clearer later as well.

@laurentlp
Copy link
Contributor

We'll look into putting the content type typings in the base package later. The send function also as a mysterious from parameter. I'll make it's usage clearer later as well.

Can you please create issues for those points so we don't forget them later?

@linear
Copy link

linear bot commented Aug 19, 2021

MES-123 Webchat

Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Awesome work 🏆

@samuelmasse samuelmasse merged commit aed8705 into master Aug 19, 2021
@samuelmasse samuelmasse deleted the sm-webchat branch August 19, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants