Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci_cd): fix changelog generation on release #146

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

laurentlp
Copy link
Contributor

@laurentlp laurentlp commented Aug 23, 2021

This PR fixes CHANGELOG generation on new release.

The process is now as follows:

// Create a new branch from an up-to-date master
git checkout -b vX_X_X
// Run yarn release to bump the package.json version and generate a changelog
yarn release <major|minor|patch>
// Commit the changes and push the branch and create a pull request
git add .
git commit -m "vX_X_X"
git push origin vX_X_X

See #147

Closes MES-37

@linear
Copy link

linear bot commented Aug 23, 2021

MES-37 The auto generated CHANGELOG.md doesn't work

In the nlu and studio repo we can see that the CHANGELOG.md gets filled with changelog from releases. However in our repo this doesn't seem to work.

Copy link
Contributor

@samuelmasse samuelmasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

We should look into rewriting all the code in the scripts folder. I don't see any reason why it has to be in javascript. We could use ts-node instead.

@laurentlp
Copy link
Contributor Author

Good job

We should look into rewriting all the code in the scripts folder. I don't see any reason why it has to be in javascript. We could use ts-node instead.

Totally agree, I created an issue to work on this later: https://linear.app/botpress/issue/MES-136/convert-scripts-to-ts-files

@laurentlp laurentlp merged commit 49e52cc into master Aug 23, 2021
@laurentlp laurentlp deleted the llp_fix_release branch August 23, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants