Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): better handling of entity not found #197

Merged
merged 2 commits into from
Oct 14, 2021
Merged

chore(api): better handling of entity not found #197

merged 2 commits into from
Oct 14, 2021

Conversation

laurentlp
Copy link
Contributor

This PR adds 404s when an entity is not found and returns undefined when using the client

@laurentlp
chore(client): better error handling (#198)
df62c65 
* chore(client): better error handling

* small refactor
@laurentlp laurentlp merged commit 0a547e2 into llp_get_user_route Oct 14, 2021
@laurentlp laurentlp deleted the llp_better_not_found_handling branch October 14, 2021 15:59
laurentlp added a commit that referenced this pull request Oct 15, 2021
@laurentlp
feat(api): add a route to get user info (#195)
7441823 
* feat(api): add a route to get user info

* pr comment

* chore(api): better handling of entity not found (#197)

* chore(api): better handling of entity not found

* chore(client): better error handling (#198)

* chore(client): better error handling

* small refactor
@EFF EFF mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmasse samuelmasse samuelmasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentlp @samuelmasse