Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(user-tokens): implement user tokens #203

Merged
merged 39 commits into from
Oct 27, 2021
Merged

feat(user-tokens): implement user tokens #203

merged 39 commits into from
Oct 27, 2021

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Oct 14, 2021 •
edited
Loading

Adds a table and a service for user tokens

Closes DEV-1613

@linear
Copy link

linear bot commented Oct 15, 2021

DEV-1613 User tokens

User tokens will enable api calls that are restricted to the resources owned by a single messaging user

  • No UI - api managed
  • Create user token table and service
  • Need a refresh token and expiry mechanism

Excludes porting of the webchat

Include user token in the socket client

Inform @nikita.pushkarskii that the documentation should be updated

@samuelmasse samuelmasse mentioned this pull request Oct 15, 2021
Closed
@samuelmasse samuelmasse mentioned this pull request Oct 15, 2021
Closed
@samuelmasse samuelmasse changed the base branch from master to sm-refact-auth October 15, 2021 01:53
@samuelmasse samuelmasse marked this pull request as ready for review October 15, 2021 01:55
laurentlp
laurentlp reviewed Oct 15, 2021
View reviewed changes
packages/server/src/user-tokens/service.ts Outdated Show resolved Hide resolved
packages/server/src/user-tokens/service.ts Show resolved Hide resolved
packages/server/src/user-tokens/service.ts Show resolved Hide resolved
packages/server/src/user-tokens/service.ts Outdated Show resolved Hide resolved
packages/server/src/user-tokens/service.ts Show resolved Hide resolved
packages/server/src/user-tokens/service.ts Show resolved Hide resolved
packages/server/src/user-tokens/api.ts Outdated Show resolved Hide resolved
@samuelmasse samuelmasse changed the base branch from sm-refact-auth to sm-refactor-auth-2 October 15, 2021 21:44
Base automatically changed from sm-refactor-auth-2 to master October 15, 2021 22:06
@samuelmasse samuelmasse mentioned this pull request Oct 25, 2021
Merged
laurentlp
laurentlp approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment but otherwise LGTM!

packages/server/src/users/api.ts Show resolved Hide resolved
@samuelmasse samuelmasse merged commit c27fb4d into master Oct 27, 2021
@samuelmasse samuelmasse deleted the sm-user-tokens branch October 27, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlp laurentlp laurentlp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelmasse @laurentlp