Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): refact implementation #223

Merged
merged 128 commits into from
Nov 5, 2021
Merged

feat(api): refact implementation #223

merged 128 commits into from
Nov 5, 2021

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Oct 26, 2021 •
edited
Loading

The code for the api was becoming a mess. Since this code does critical work for safety I needs to be refactored to be maintainable.

Todo:

  • Update documentation for changed routes
  • Open PR in core and runtime that updates the messaging version
  • Update message deletion function

Closes DEV-1945

@samuelmasse
user token start
20feba1
@samuelmasse
Merge branch 'master' into sm-user-tokens
40f6abb
@samuelmasse
tests
ff8413d
@samuelmasse
refactor auth
abf152e
@samuelmasse
caching
913745d
@samuelmasse
api
9756f31
@samuelmasse
fix test
88d6b7b
@samuelmasse
comment
40792a8
@samuelmasse
expiry
3b7ff5a
@samuelmasse
batching
3607295
@samuelmasse
remove user token implementation
1e1dd78
@samuelmasse
Revert "remove user token implementation"
7a7201a 
This reverts commit 1e1dd78.
@samuelmasse
refact auth
4883b76
@samuelmasse
Merge branch 'sm-refact-auth' into sm-user-tokens
cded7d2
@samuelmasse
remove file
03c0d2c
@samuelmasse
Merge branch 'sm-refact-auth' into sm-user-tokens
ca0bf88
@samuelmasse
fix
e30f53d
@samuelmasse
refact client auth function
d71d38a
@samuelmasse
refact function
f864d62
@samuelmasse
Merge branch 'sm-refact-auth' into sm-user-tokens
18feb11
@samuelmasse
refact
6591ab7
@samuelmasse
fix
4041f2d
@samuelmasse
Merge branch 'sm-refactor-auth-2' into sm-user-tokens
ba2b862
@samuelmasse
remove file
66af424
@samuelmasse
Merge branch 'sm-refactor-auth-2' into sm-user-tokens
b5e9cf0
@samuelmasse
Merge branch 'master' into sm-user-tokens
42aa6c0
@samuelmasse
Merge branch 'master' into sm-user-tokens
dc8c655
@samuelmasse
end turn route
6d39ca2
@samuelmasse
responses
b1ac7b8
@samuelmasse
return message also
fe526fe
Base automatically changed from sm-ui-new-socket to master October 29, 2021 18:13
samuelmasse
samuelmasse commented Nov 3, 2021
View reviewed changes
Copy link
Contributor Author

@samuelmasse samuelmasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurentlp I think this is good to merge now. There'll be 1 or 2 other PRs mostly for code refactors but the routes renaming should all be in this PR.

packages/client/jest.config.ts Show resolved Hide resolved
api.rest Show resolved Hide resolved
packages/server/src/conversations/api.ts Outdated Show resolved Hide resolved
packages/server/src/base/schema.ts Show resolved Hide resolved
packages/client/src/messages.ts Outdated Show resolved Hide resolved
@samuelmasse samuelmasse marked this pull request as ready for review November 3, 2021 00:46
laurentlp
laurentlp reviewed Nov 3, 2021
View reviewed changes
packages/server/src/base/api-manager.ts Show resolved Hide resolved
packages/server/src/base/api-manager.ts Outdated Show resolved Hide resolved
packages/server/src/conversations/api.ts Outdated Show resolved Hide resolved
packages/server/src/conversations/api.ts Outdated Show resolved Hide resolved
packages/server/src/conversations/api.ts Show resolved Hide resolved
packages/server/src/messages/api.ts Outdated Show resolved Hide resolved
packages/server/src/messages/schema.ts Outdated Show resolved Hide resolved
packages/server/src/messages/schema.ts Outdated Show resolved Hide resolved
packages/server/src/sync/api.ts Show resolved Hide resolved
packages/server/src/conversations/api.ts Show resolved Hide resolved
laurentlp
laurentlp approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work here, as usual!!!! 💯

@laurentlp laurentlp mentioned this pull request Nov 5, 2021
Merged
5 tasks
@laurentlp laurentlp merged commit c8aa881 into master Nov 5, 2021
@laurentlp laurentlp deleted the sm-refact-api branch November 5, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlp laurentlp laurentlp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelmasse @laurentlp