Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): client tokens #298

Merged
merged 18 commits into from
Jan 13, 2022
Merged

feat(client): client tokens #298

merged 18 commits into from
Jan 13, 2022

Conversation

samuelmasse
Copy link
Contributor

Changes how client tokens work to work the same way as user tokens.

Closes DEV-2205

@linear
Copy link

linear bot commented Jan 10, 2022

DEV-2205 Adjust the client tokens to work the same as user tokens (allow multiple tokens)

@samuelmasse
Copy link
Contributor Author

Not mergeable yet. We need to do a migration and also figure out how we will migrate the tokens in botpress, since this PR invalidates them.

@samuelmasse samuelmasse marked this pull request as ready for review January 12, 2022 17:50
laurentlp
laurentlp reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it LGTM! Brilliant job here!

packages/server/src/migrations/0.1.21-client-tokens.ts Show resolved Hide resolved
packages/server/test/migration/0.1.20-fix-client-schema.test.ts Show resolved Hide resolved
packages/server/test/security/api.test.ts Show resolved Hide resolved
packages/server/test/security/api.test.ts Outdated Show resolved Hide resolved
packages/server/src/sync/schema.ts Outdated Show resolved Hide resolved
packages/server/src/client-tokens/service.ts Outdated Show resolved Hide resolved
packages/server/src/client-tokens/service.ts Show resolved Hide resolved
packages/server/test/integration/client-tokens.test.ts Show resolved Hide resolved
packages/server/test/integration/client-tokens.test.ts Show resolved Hide resolved
@samuelmasse samuelmasse merged commit 709f120 into master Jan 13, 2022
@samuelmasse samuelmasse deleted the sm-client-tokens branch January 13, 2022 17:47
@EFF EFF mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlp laurentlp laurentlp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelmasse @laurentlp