feat(teams): teams v1 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmasse
commented
Feb 2, 2022
Comment on lines
+21
to
+23
| | Quick Reply | ✅ | | ||
| | Postback | ✅ | | ||
| | Say Something | ✅ | |
There was a problem hiding this comment.
I sorted these out. Turns out this channel only received text, even if it was quick reply, postback and say something. Now all three work.
Comment on lines
+4
to
+7
| export interface TeamsConfig extends ChannelConfig { | ||
| appId: string | ||
| appPassword: string | ||
| } |
There was a problem hiding this comment.
Removed the tenantId here because I don't know what it's used for. We can add it back if we need it.
There was a problem hiding this comment.
I think it was for some validation but I'm not sure either.
laurentlp
approved these changes
Feb 2, 2022
Comment on lines
+4
to
+7
| export interface TeamsConfig extends ChannelConfig { | ||
| appId: string | ||
| appPassword: string | ||
| } |
There was a problem hiding this comment.
I think it was for some validation but I'm not sure either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades teams to be version 1.0.0. Added more content types and fixed some things. As for the API version nothing really changed for this channel. We were using botbuilder 4.14.0 before and now we use 4.15.0
Closes DEV-2277