Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): allow specifying a custom client id #343

Merged
merged 6 commits into from
Feb 9, 2022
Merged

feat(clients): allow specifying a custom client id #343

merged 6 commits into from
Feb 9, 2022

Conversation

samuelmasse
Copy link
Contributor

Closes DEV-2317

@linear
Copy link

linear bot commented Feb 9, 2022

DEV-2317 Allow specifying a custom id on client creation

@samuelmasse
Copy link
Contributor Author

Note: release new version of @botpress/messaging-client before merging this

@samuelmasse samuelmasse marked this pull request as ready for review February 9, 2022 21:47
laurentlp
laurentlp approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@samuelmasse samuelmasse merged commit cd42f30 into master Feb 9, 2022
@samuelmasse samuelmasse deleted the sm-custom-client-id branch February 9, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlp laurentlp laurentlp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelmasse @laurentlp