Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(teams): error crashing server #370

Merged
merged 5 commits into from
Feb 17, 2022
Merged

fix(teams): error crashing server #370

merged 5 commits into from
Feb 17, 2022

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Feb 17, 2022

Also need to prevent the server from crashing when sending two reponses to a http request

Related changes on v1 : f485ae2

Fixes #369

Closes DEV-2358

@linear
Copy link

linear bot commented Feb 17, 2022

@samuelmasse samuelmasse marked this pull request as ready for review February 17, 2022 17:30
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samuelmasse samuelmasse merged commit 46269bc into master Feb 17, 2022
@samuelmasse samuelmasse deleted the sm-fix-teams branch February 17, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: when an invalid appID is configured the app is crashing
2 participants