Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review setup*.py files in root-directory #24

Open
woutervh opened this issue Dec 8, 2016 · 3 comments
Open

review setup*.py files in root-directory #24

woutervh opened this issue Dec 8, 2016 · 3 comments

Comments

@woutervh
Copy link
Collaborator

woutervh commented Dec 8, 2016

I made setup.py
the other ones seems very old-style.

And since we can now use "pip install", it does not make sense to build windows-executables
IMHO we no longer need the other setup_*.py files

@djfurman
Copy link
Member

I agree that those are no longer necessary.

Using your revised setup.py script; can the declared dependencies be installed directly (by using something other than pip install bots or python setup.py install)? Or would it be helpful to add a requirements.txt file?

Admittedly, I'm somewhat of a newbie when it comes to python deployment best practices.

@dwoz
Copy link

dwoz commented Jul 18, 2017

+1 on requirements.txt

@sdwarwick
Copy link

Any chance of testing against python 3.7? have moved almost everything we do to this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants