Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

po: update POTFILES, PO files; make translator credits a translatable string #2823

Merged
merged 3 commits into from
Apr 2, 2023

Conversation

kbdharun
Copy link
Contributor

@kbdharun kbdharun commented Mar 27, 2023

Description

  • Updated POTFILES as connection.py component was removed.
  • Updated POT files and PO Files.
  • Currently, translator credits are maintained manually which is tedious to maintain (and it hasn't been maintained), I propose making it a translatable term instead so the credits for translators are shown when people are accessing it in the respective languages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Only POTFILES was manually touched, translation files are able to be updated with Meson using the following commands:
meson setup /tmp/translation-build
meson compile -C /tmp/translation-build bottles-pot
meson compile -C /tmp/translation-build bottles-update-po

… string

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun changed the title po: update POTFILES, PO files; make translator credits a translatable… po: update POTFILES, PO files; make translator credits a translatable string Mar 27, 2023
@github-actions
Copy link
Contributor

Pylint result on modfied files:

@kbdharun kbdharun marked this pull request as draft April 2, 2023 10:30
@kbdharun kbdharun marked this pull request as ready for review April 2, 2023 18:11
@TheEvilSkeleton
Copy link
Contributor

Currently, translator credits are maintained manually which is tedious to maintain (and it hasn't been maintained), I propose making it a translatable term instead so the credits for translators are shown when people are accessing it in the respective languages.

You have my support 👍

@TheEvilSkeleton TheEvilSkeleton merged commit c87268d into bottlesdevs:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants