Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using Box<> / ObjectIdentifier for subscribers #5

Closed
Bouke opened this issue Apr 12, 2017 · 1 comment
Closed

Stop using Box<> / ObjectIdentifier for subscribers #5

Bouke opened this issue Apr 12, 2017 · 1 comment

Comments

@Bouke
Copy link
Owner

Bouke commented Apr 12, 2017 •
edited
Loading

I don't like the way this is implemented as a result of Characteristic being a protocol, therefore not being able to participate in heterogeneous collections. Possible alternatives:

  • Store subscribers on the characteristic themselves -- however I don't like having the characteristics keeping a reference to the connections
  • Some other way of identifying characteristics, we must know which connections subscribed to which characteristics
@Bouke Bouke added the ready label Apr 15, 2017
@Bouke Bouke removed the ready label Jan 7, 2018
@Bouke Bouke mentioned this issue Jan 30, 2018
Closed
@Bouke
Copy link
Owner Author

Bouke commented Dec 15, 2018

Box is removed in #68. ObjectIdentifier is fine I guess.

@Bouke Bouke closed this as completed Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bouke