Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept wider variety of LCSC property names from schematic #40

Closed
Bouni opened this issue Oct 14, 2021 · 2 comments
Closed

Accept wider variety of LCSC property names from schematic #40

Bouni opened this issue Oct 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Bouni
Copy link
Owner

Bouni commented Oct 14, 2021

At the moment we only accept LCSC propertys set in the schematic if the are named LCSC, all upercase, no leading or trailing whitespaces.

Maybe we should accept lower case and/or mixed variants like Lcsc LCsc lcsc and so on as well.
The same applies for LCSC, LCSC etc.

@Bouni Bouni added the enhancement New feature or request label Oct 14, 2021
@bvernoux
Copy link
Contributor

Could you also accept properties which contains LCSC as on my old design I was using LCSC_Part for example ?

@Bouni
Copy link
Owner Author

Bouni commented Oct 14, 2021

Sure!
I opened this issue on purpose so that we can decide what we should do in order to help people using this plugin as much as possibel!

@Bouni Bouni closed this as completed in 710c0b3 Oct 21, 2021
Bouni added a commit that referenced this issue Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants