Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search pull request #626

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Conversation

Aidavhd
Copy link

@Aidavhd Aidavhd commented Jul 3, 2020


name: Search and Pull requests
about: descriptors and execution records search and pull
title: 'search-pull'
labels: enhancement
assignees: ''


Related issues

Checklist

  • DO Unit tests pass.
  • DO If new feature, created unit test.
  • TRY If new API function, documented it (refer to
    PEP 257).

Purpose

Search and pull execution records and descriptors from Zenodo

Current behaviour

Search and pull descriptor

New behaviour

Search and pull execution records added

Does this introduce a major change?

  • Yes
  • No

Implementation Detail

Searcher and puller which is related to descriptors updated and functions moved to zenodoHelper.
Functions added to bosh and dataHandler to apply search and pull for execution records by calling functions in zenodoHelper.
Functions of search and pull added to zenodoHelper for handling both execution records and descriptor search/pull.
Add tests about execution record pull and search to test_data_handler.

Adding function to bosh for search and pull execution records
Updating searcher.py, move functions to zenodoHelper
Update puller.py, move functions to zenodoHelper
Adding functions for search and pull execution records from Zenodo
Adding search and pull function to zenodoHelper for searching and pulling descriptors and execution records.
Testing functions added to dataHandler for search and pull of execution records
@coveralls
Copy link

coveralls commented Jul 3, 2020

Coverage Status

Coverage increased (+0.05%) to 94.144% when pulling 2ff1213 on Aidavhd:search_pull_request into 64b0f1d on boutiques:develop.

@glatard
Copy link
Member

glatard commented Aug 20, 2020

This now looks very good! Let me try this feature before we merge.

@DarrinFong
Copy link
Contributor

New conflicts have been resolved in this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants