3D fixes for the python interface #2374
Conversation
Use spaces not tabs
…o coord3d_merged2
constexpr need to be known at compile time
…-dev into coord3d_merged2
Fixed with: grep not\ metric_3d tests -r --include=runtest|cut -d: -f1 |sed 's/runtest/CMakeLists.txt/' | xargs -n 1 sed -e '3 i \ REQUIRES NOT BOUT_USE_METRIC_3D'
Make submodules improvements
Fix test_coordinates
* next: Mark unused function arguments with MAYBE_UNUSED De-abbreviate exception message Use constants in setting default_dz for Coordinates unit test Fix expectation for default value Do not ignore default value Fix mpark_submodule if not called from local directory Add additional targets for submodules Some basic tests of Coordinates inputs Basic tests of Coordinates Enable FakeGridDataSource to provide values to Mesh
strings ending in -NOTFOUND are False Co-authored-by: Peter Hill <zed.three@gmail.com>
Update documentation for ctest and Github Actions
CMake: Add SOVERSION; fix FindSUNDIALS
Guard use of FFTW constants Fixes #2370
Helps preserve ABI
Fix for compiling without FFTW
Copy-paste error, extracting data from wrong Vec Shouldn't have affected any results, since only affects preconditioner, but might have made preconditioners less effective than they could have been.
Vec is locked by PETSc (at least in 3.20), so need read-only access. Since `load_vars` takes a `BoutReal*`, a `const_cast` is needed for now.
Bug fixes for imex-bdf2 solver
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| BoutReal zlength() const { return dz * nz; } ///< Length of the Z domain. Used for FFTs | ||
| FieldMetric dx, dy, dz; ///< Mesh spacing in x, y and z |
There was a problem hiding this comment.
warning: member variable dx has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric dx, dy, dz; ///< Mesh spacing in x, y and z
^|
|
||
| BoutReal zlength() const { return dz * nz; } ///< Length of the Z domain. Used for FFTs | ||
| FieldMetric dx, dy, dz; ///< Mesh spacing in x, y and z |
There was a problem hiding this comment.
warning: member variable dy has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric dx, dy, dz; ///< Mesh spacing in x, y and z
^|
|
||
| BoutReal zlength() const { return dz * nz; } ///< Length of the Z domain. Used for FFTs | ||
| FieldMetric dx, dy, dz; ///< Mesh spacing in x, y and z |
There was a problem hiding this comment.
warning: member variable dz has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric dx, dy, dz; ///< Mesh spacing in x, y and z
^|
|
||
| Field2D J; ///< Coordinate system Jacobian, so volume of cell is J*dx*dy*dz | ||
| /// 2nd-order correction for non-uniform meshes d/di(1/dx), d/di(1/dy) and d/di(1/dz) | ||
| FieldMetric d1_dx, d1_dy, d1_dz; |
There was a problem hiding this comment.
warning: member variable d1_dx has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric d1_dx, d1_dy, d1_dz;
^|
|
||
| Field2D J; ///< Coordinate system Jacobian, so volume of cell is J*dx*dy*dz | ||
| /// 2nd-order correction for non-uniform meshes d/di(1/dx), d/di(1/dy) and d/di(1/dz) | ||
| FieldMetric d1_dx, d1_dy, d1_dz; |
There was a problem hiding this comment.
warning: member variable d1_dy has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric d1_dx, d1_dy, d1_dz;
^| Field2D G1, G2, G3; | ||
|
|
||
| Field2D ShiftTorsion; ///< d pitch angle / dx. Needed for vector differentials (Curl) | ||
| FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23; |
There was a problem hiding this comment.
warning: member variable G1_11 has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23;
^| Field2D G1, G2, G3; | ||
|
|
||
| Field2D ShiftTorsion; ///< d pitch angle / dx. Needed for vector differentials (Curl) | ||
| FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23; |
There was a problem hiding this comment.
warning: member variable G1_22 has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23;
^| Field2D G1, G2, G3; | ||
|
|
||
| Field2D ShiftTorsion; ///< d pitch angle / dx. Needed for vector differentials (Curl) | ||
| FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23; |
There was a problem hiding this comment.
warning: member variable G1_33 has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23;
^| Field2D G1, G2, G3; | ||
|
|
||
| Field2D ShiftTorsion; ///< d pitch angle / dx. Needed for vector differentials (Curl) | ||
| FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23; |
There was a problem hiding this comment.
warning: member variable G1_12 has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23;
^| Field2D G1, G2, G3; | ||
|
|
||
| Field2D ShiftTorsion; ///< d pitch angle / dx. Needed for vector differentials (Curl) | ||
| FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23; |
There was a problem hiding this comment.
warning: member variable G1_13 has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]
FieldMetric G1_11, G1_22, G1_33, G1_12, G1_13, G1_23;
^
No description provided.