5.1 release candidate #2720
5.1 release candidate #2720
Conversation
We need to link with gcov to get gcda files. Further, they are in the build directories, not the source directories.
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
* support sudo without password * set actually a password * Use --build-args rather then bash script to generate Dockerfile
* next: (517 commits) Apply clang-format Fix some clang-tidy suggestions in PCR Thomas Remove duplicated header in Laplace PCR Thomas Fix type of `Coordinates::zlength/dz` in Laplace PCR Thomas Fix `LaplacePCR_THOMAS` constructor for new Laplace parameters Docs: Fix some formatting issues Docs: Fix some broken tables Docs: Fix some xBout links Docs: Remove outdated note Docs: Fix some whitespace Docs: Update Ubuntu instructions Docs: Explain some common CMake options Docs: Add a short quickstart guide with basic instructions Docs: Move and expand section on building examples/models with CMake Docs: Whitespace cleanup Docs: Expand basic CMake docs Docs: Note that configure is deprecated Docs: Remove out-dated note Docs: Use `https` instead of `git` protocol Remove some useless forward declarations ...
Remove h5py - we only support netcdf
Improving compatibility with fmt 10
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -111,6 +115,14 @@ public: | |||
| */ | |||
| static void cleanup(); | |||
|
|
|||
| static inline void assertIerr(PetscErrorCode ierr, std::string op = "PETSc operation") { | |||
There was a problem hiding this comment.
warning: the parameter 'op' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
| static inline void assertIerr(PetscErrorCode ierr, std::string op = "PETSc operation") { | |
| static inline void assertIerr(PetscErrorCode ierr, const std::string& op = "PETSc operation") { |
| @@ -111,6 +115,14 @@ public: | |||
| */ | |||
| static void cleanup(); | |||
|
|
|||
| static inline void assertIerr(PetscErrorCode ierr, std::string op = "PETSc operation") { | |||
There was a problem hiding this comment.
warning: parameter name 'op' is too short, expected at least 3 characters [readability-identifier-length]
static inline void assertIerr(PetscErrorCode ierr, std::string op = "PETSc operation") {
^| @@ -111,6 +115,14 @@ public: | |||
| */ | |||
| static void cleanup(); | |||
|
|
|||
| static inline void assertIerr(PetscErrorCode ierr, std::string op = "PETSc operation") { | |||
| if (ierr) { | |||
There was a problem hiding this comment.
warning: implicit conversion 'PetscErrorCode' (aka 'int') -> bool [readability-implicit-bool-conversion]
| if (ierr) { | |
| if (ierr != 0) { |
| @@ -135,4 +124,17 @@ void PetscLib::setPetscOptions(Options& options, const std::string& prefix) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| BoutException PetscLib::SNESFailure(SNES& snes) { | |||
| SNESConvergedReason reason; | |||
There was a problem hiding this comment.
warning: variable 'reason' is not initialized [cppcoreguidelines-init-variables]
SNESConvergedReason reason;
^| SNESConvergedReason reason; | ||
| BOUT_DO_PETSC(SNESGetConvergedReason(snes, &reason)); | ||
| #if PETSC_VERSION_GE(3, 15, 0) | ||
| const char* message; |
There was a problem hiding this comment.
warning: variable 'message' is not initialized [cppcoreguidelines-init-variables]
| const char* message; | |
| const char* message = nullptr; |
Fix FV::Div_a_Grad_perp Y alignment
|
I think this is essentially all the maintenance tasks done and we're ready to go @bendudson The Fedora tests are still failing, but that is an issue with either Fedora or Github. |
|
The python package CI are all failing, I guess because it's looking for a tag 5.1.0 which doesn't exist yet. |
|
Yes, the python package only needs bumping after the release. If the release is a tag, it should "do the right thing" :-) |
[skip ci]
We've got into a bit of mess between
masterandnext, and I don't have a great deal of time to sort it out, so the simplest thing is to get everything into master and release 5.1.New and currently open PRs into
nextshould target this branch now.Making a New Release of BOUT++
This is checklist of things to do (in order) when making a new
release. This applies equally to both major/minor releases and bugfix
releases
vX.Y.Z-rcX/Y) should be offnext. Bugfix releases (Z) should be offmastermaster"bugfixes" can include:
make check-allclang-tidy,clang-check,coverity, etc.Before merging PR:
make -C locale update-allreorder file paths in the .po and .pot files
CHANGELOG.md:bout-changelog-generator.py LAST_RELEASE NEXT_RELEASEgit log --format='%aN' | sort | uniqCITATION.cff, add new authorsCITATION.cffto new DOIREADME.mdto new DOICITATION.cffabidiffto see ifsonameneeds bumping inmakefile:configure.ac:AC_INITCITATION.cff:versionmanual/sphinx/conf.py:versionandreleasemanual/doxygen/Doxyfile_readthedocs:PROJECT_NUMBERmanual/doxygen/Doxyfile:PROJECT_NUMBERCMakeLists.txt:_bout_previous_version,_bout_next_versiontools/pylib/_boutpp_build/backend.py:_bout_previous_version,_bout_next_versionAfter PR is merged:
leading
vcmake -S . -B build && make dist -C buildmasterintonextconfigure.ac:AC_INITCITATION.cff:versionmanual/sphinx/conf.py:versionandreleasemanual/doxygen/Doxyfile_readthedocs:PROJECT_NUMBERmanual/doxygen/Doxyfile:PROJECT_NUMBERCMakeLists.txt:_bout_previous_version,_bout_next_versiontools/pylib/_boutpp_build/backend.py:_bout_previous_version,_bout_next_version