Introduce class name changes in new namespace #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested vfs-stream-examples and some of my project against this, and both an update without any namespace and class name adoptions in the project and adopting the new namespace with the new class names went without any problems. Maybe if you have some projects depending on vfsStream you could do the same to ensure we really deliver a seamless upgrade experience. Just because it went fine in my projects doesn't mean it will in others. |
bizurkur
approved these changes
Mar 10, 2020
2 tasks
allejo
approved these changes
Mar 18, 2020
|
I surely want to do this, but think I don't have time to do it this month. So feel free to merge this PR and I will report any issues. Maybe we can come up with some phprector script to help people upgrade? |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the class name changes proposed with #213 into the v1.x series according to the migration strategy detailed in #221.
In case you are wondering about duplication of TestCase classes - I doubled some of them, keeping the old version targeted at the
org\bovigo\vfsnamespace, and for the renamed classes I introduced the same TestCase classes using the renamed classes. This should help to ensure that everything is compatible in the way we expect it to be.