Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations to indicate return type will change #261

Merged
merged 1 commit into from Aug 2, 2021

Conversation

alexpott
Copy link
Contributor

@alexpott alexpott commented Jul 31, 2021

This is the fix for v1.6 on PHP 8.1 - related to #260

Fixes #259
Fixes #258

@allejo allejo merged commit f7f4dcd into bovigo:v1.6 Aug 2, 2021
@allejo
Copy link
Member

allejo commented Aug 2, 2021

Thank you for the PR!

SpacePossum added a commit to PHP-CS-Fixer/PHP-CS-Fixer that referenced this pull request Dec 1, 2021
This PR was merged into the master branch.

Discussion
----------

DX: test on PHP 8.1

Changes in `composer.json` must be reverted, this require:

- [x] [justinrainbow/json-schema](https://github.com/justinrainbow/json-schema) to be released with the fix: justinrainbow/json-schema#666
- [x] [mikey179/vfsstream](https://github.com/bovigo/vfsStream) new v1 version to be released
- [x] [mikey179/vfsstream](https://github.com/bovigo/vfsStream) another version (with bovigo/vfsStream#261) to be released
- [x] [symfony/symfony](https://github.com/symfony/symfony) new version (with symfony/symfony#42260) to be released

Commits
-------

a4358ec Test on PHP 8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants