forked from fedora-infra/bodhi
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Display the push to batched button for pushed updates.
The HTML template code is crazy[0,1] and its craziness was underestimated when the batching feature was first written. It turns out that it would only display the push to batched button for unpushed updates. This commit refactors the template code to be slightly less crazy (further refactoring is certainly needed), and displays that button on pushed updates. It also adds several test cases to assert that the correct buttons appear at the right times. These new tests revealed that the CI tests were leaking state, as they would pass on their own but fail if the CI tests were run first. Thus, this commit also refactors the CI tests to stop leaking state by using mock. fixes fedora-infra#1875 re fedora-infra#1887 re fedora-infra#1888 [0] fedora-infra#1887 [1] fedora-infra#1888 Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
- Loading branch information
1 parent
47ed7e4
commit 7ab232c
Showing
5 changed files
with
324 additions
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.