chore(node): Upgrade node dependency to 12.x #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also removes a duplicate node-sass version from yarn.lock
|
Verified that @j3tan has signed the CLA. Thanks for the pull request! |
|
Also a question on whether we need to upgrade |
j3tan
commented
Jan 23, 2020
| @@ -18618,31 +18564,6 @@ node-sass@^4.13.1: | |||
| stdout-stream "^1.4.0" | |||
| "true-case-path" "^1.0.2" | |||
|
|
|||
| node-sass@^4.9.3: | |||
There was a problem hiding this comment.
this is the duplicate yarn.lock that causes issues if you try to yarn install on node@12.x
jstoffan
previously approved these changes
Jan 23, 2020
jstoffan
previously approved these changes
Jan 23, 2020
jstoffan
previously approved these changes
Jan 23, 2020
priyajeet
suggested changes
Jan 23, 2020
BREAKING CHANGE: Minimum version of node for box-ui-elements bumped to 10.x
j3tan
force-pushed
the
upgrade-to-node-12
branch
from
c70b81e
to
7a6c641
Compare
priyajeet
previously approved these changes
Jan 23, 2020
j3tan
commented
Jan 23, 2020
| @@ -12837,21 +12791,13 @@ fs.realpath@^1.0.0: | |||
| resolved "https://registry.yarnpkg.com/fs.realpath/-/fs.realpath-1.0.0.tgz#1504ad2523158caa40db4a2787cb01411994ea4f" | |||
| integrity sha1-FQStJSMVjKpA20onh8sBQRmU6k8= | |||
|
|
|||
| fsevents@^1.2.2: | |||
There was a problem hiding this comment.
also had Node 12 issue
priyajeet
approved these changes
Jan 24, 2020
ehoogerbeets
pushed a commit
to ehoogerbeets/box-ui-elements
that referenced
this pull request
Feb 5, 2020
* chore(node): Upgrade node dependency to 12.x This commit also removes a duplicate node-sass version from yarn.lock * ci(node): Upgrade node to 12 on CI machines * ci: Remove travis references * docs: Remove travis references * chore(node): Bump minimum node version to 10.x BREAKING CHANGE: Minimum version of node for box-ui-elements bumped to 10.x * chore(node): Removed old version of fsevents from yarn.lock Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also removes a duplicate node-sass version from yarn.lock
If you run encounter an issue with
yarn installsuch as:Verify you have
node@12installed vianvmand removenode_modules/sass-variable-parser