Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File extensions does not have to be .alert .dashboard #5

Open
ahakanbaba opened this issue Jun 9, 2018 · 0 comments
Open

File extensions does not have to be .alert .dashboard #5

ahakanbaba opened this issue Jun 9, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@ahakanbaba
Copy link
Contributor

We are talking about the files where wavectl stores the json representation of resources. ( Alerts or Dashboards)

The file syntax is actually .json.
So for IDE support aspect, it makes sense to use the extension json.

The wavectl command could read the expected extension in an environment variable. But, I am actually not sure whether this is necessary. I do not think there is anything fundamental in the implementation that would break if we changed the .alert extension to .json.

In wavectl commands the user needs to specify the resource type already. For example
wavectl pull

alert
wavectl push dashboard

So as long as the pull and the push command's file extension expectations are the same, using .json should work simply.

@ahakanbaba ahakanbaba added the enhancement New feature or request label Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant