Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening weblinks, sync messages on first load #67

Closed
BennyThadikaran opened this issue Jul 2, 2021 · 4 comments
Closed

Opening weblinks, sync messages on first load #67

BennyThadikaran opened this issue Jul 2, 2021 · 4 comments

Comments

@BennyThadikaran
Copy link

There is no way to open weblinks in a message. I expected mouse right click to open link in web browser.
But mouse in entirely disabled in Messages area.

After installing on first run, i expected gurk to sync my old messages. Once device is linked, new messages do sync up.

First time filing an issue, apologies for any mistakes.

Overall I love the idea of a terminal client. Much faster than the GUI desktop app. Thanks for your efforts :)

@Sup3Legacy
Copy link
Contributor

Hi!

I totally agree with the idea of clickable links, this would be a nice feature.

Regarding the synchronization of old messages, I am pretty confident Signal specifically does not allow new devices to do this. So I guess this will not be possible.

@BennyThadikaran
Copy link
Author

BennyThadikaran commented Jul 5, 2021

Thanks, Synchronization isnt critical. Once the device is linked, all future messages are synced.

Gurk starts off all empty. So there is nothing to click or work with until you send / receive a message.
Ctrl - C to quit the app is not very clear initially. The help section is also a bit sparse on information on using the app.

I'm really like your app. You should totally reach out to youtubers like Brodie Robertson and DistroTube. They've been featuring Rust apps on their channel lately

@cauebs
Copy link

cauebs commented Jul 5, 2021

Hello! You have some very constructive criticism. Might I suggest that you open individual issues to describe and track each suggestion?

@boxdot
Copy link
Owner

boxdot commented Jul 6, 2021

@BennyThadikaran Thank you for filing this issue. This is very valuable.
@Sup3Legacy and @cauebs Thank you for your suggestions.

  1. Initial sync of message is not implemented by Signal on purpose (as it was already pointed out by @Sup3Legacy). To my understanding groups v2 are also not synced automatically for new devices. They are synced on first message after a new device was linked. I might be wrong though, @gferon knows more about this feature. Regarding sync contacts, this is definitely a must feature and we should implement it: Sync contacts on initial device linking #69

  2. About opening links: mouse interface might be a little bit involved. The reason for not having mouse interaction with messages atm is that messages are wrapped and we need to keep track of each message location. This is not yet done. However, an easy solution would be to select a message with alt+up/down (already works) and press enter. If there is a link, it can be then opened. Same can be done for attachments (not implemented atm). Open links #70

  3. A help section would be indeed useful. For the beginning, we could add the shortcuts in the README (or somewhere else in the repo). Maybe we want also to have a screen in the app showing all shortcuts. Document all shortcuts #71

I hope I addressed all suggestions in the above issues. So, closing this for now.

@boxdot boxdot closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants