Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages from "self" show as "Unknown Name" sender #76

Closed
chaseadam opened this issue Jul 14, 2021 · 2 comments · Fixed by #78
Closed

Messages from "self" show as "Unknown Name" sender #76

chaseadam opened this issue Jul 14, 2021 · 2 comments · Fixed by #78

Comments

@chaseadam
Copy link

chaseadam commented Jul 14, 2021

Any message sent by me on any device shows up as "Unknown Name" sender. I have my "Name" set in the Signal App (on phone) and in gurk.toml:

[user]
name = "<Name>"
phone_number = "+1<10 digit number>"

I do note that the from_id of the message is not present in names JSON sub-document of gurk.data.json.

Should a "self" id populate automatically?

I am new to rust, so not quite sure how to trace this back yet.

names.get(&id).map(|s| s.as_ref()).unwrap_or("Unknown Name")

@boxdot
Copy link
Owner

boxdot commented Jul 14, 2021

Thank you for reporting this bug. It is a little bit hard for me to reproduce it. Could you please verify if this fix works for you: #78? You can install gurk from the branch with:

cargo install --git https://github.com/boxdot/gurk-rs --branch phone-number-formatting

@gertjanvanzwieten
Copy link

I had exactly the same issue, and just confirmed that the phone-number-formatting branch fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants