You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 22, 2018. It is now read-only.
I've noticed that the Compressed App provider checks what it has to download by only looking at the file extension. In my opinion it should indeed better use the HTTP headers the server sends back and only rely on the file extension as a fallback.
Why this change you would ask?
There are some app providers that do not provide a direct link to the compressed file, they do send a Content-Disposition: attachment; filename="App.zip" indeed.
Also, I think the script should follow HTTP redirects.
While I'm not a ruby developer, I would love someone taking care of this issue.
The text was updated successfully, but these errors were encountered:
I know this is an old comment, but FWIW, I was able to work around this issue luca pointed out simply by using flavor => 'zip' in the package declaration for a compressed_app package whose source url didn't end in .zip.
I've noticed that the Compressed App provider checks what it has to download by only looking at the file extension. In my opinion it should indeed better use the HTTP headers the server sends back and only rely on the file extension as a fallback.
Why this change you would ask?
There are some app providers that do not provide a direct link to the compressed file, they do send a
Content-Disposition: attachment; filename="App.zip"
indeed.Also, I think the script should follow HTTP redirects.
While I'm not a ruby developer, I would love someone taking care of this issue.
The text was updated successfully, but these errors were encountered: